Alchemy is a decent money maker, but you tend to eat your own product, like a dope dealer that is addicted to his own stuff.

Mining and Jewelcrafting is a decent money maker, but a lot of work.

Don't be fooled by the other professions, as much as it takes to get them up to par, you'll never get the money back out. My current main, my lock, is tailor/enchanter and I'd hate to think about how much gold I've dumped into it, but now that I have a few decent recipes, and have heroic badges coming out of my ears for nethers, they both make ok money, but I don't think they'll ever pay for themselves even having nice reicpes. I have both whitemend recipes, both spellstrike recipes, both battlecast recipes, belt of blasting, girdle of ruination, vengeance wrap, and a few other good ones(I'm the guild tailor), but I'm lucky to make one or two a week and I usually only charge for 150-300g for my nether(depending what guild it is and how gullible the person is). I actually sell more runic spellthread than anything else. With enchanting, I take what I can get, people don't understand how many days and months you waste collecting recipes, so they think your 10 seconds of putting mongoose on their MH is worth 2g, or slapping soulfrost on their 2h should be free since it requires no effort to actually enchant it. I can't complain about executioner though, because our first ZA run ever it dropped 3 times lol. I've done maybe 10 of those, but still not enough gold compared to how much I put in to max my stats. People won't stop to think that the rod you use to enchant their stuff took over 1000g worth of mats, or that you wasted a week farming geomancers for their spellpower to bracers enchant.

Short and sweet, you want money Herbalism and mining. My hunter is herb/mining and makes enough gold to support 3 other 70s and a leveling rogue. 3 out of 4 of my 70s have epic flying and I should have enough for my 4th in a week or so.

WoW Gold scam that's easy and works!